fix(es/typescript): Handle unicode for fast ts strip #9202
Merged
+125
−13
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
magic-akari
changed the title
oxalica
reviewed
Jul 11, 2024
Comment on lines
+674
to
+675
| // This is bit magic equivalent to: b < 128 || b >= 192 | ||
| (*self as i8) >= -0x40 |
There was a problem hiding this comment.
Is this copied from some legacy code, or eyeball optimized? The expression in comment compiles to exact same code with the "optimized" one: https://godbolt.org/z/KsqjM8jad
IMO, readability is more important if they are actually the same.
There was a problem hiding this comment.
Copy from std::core::num::u8
CodSpeed Performance ReportMerging #9202 will improve performances by 5.84%Comparing Summary
Benchmarks breakdown
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
BREAKING CHANGE:
Related issue (if exists):