Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(es/parser): Add a check before numeric operations #9105

Merged
merged 1 commit into from
Jun 25, 2024
Merged

perf(es/parser): Add a check before numeric operations #9105

merged 1 commit into from
Jun 25, 2024
+1 −1

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Jun 25, 2024

Description:

c.is_ascii_uppercase() was expensive than expected.

@kdy1 kdy1 added this to the Planned milestone Jun 25, 2024
@kdy1 kdy1 self-assigned this Jun 25, 2024
@kdy1 kdy1 requested a review from a team as a code owner June 25, 2024 10:49
kdy1
kdy1 commented Jun 25, 2024
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_core
  • swc_ecma_parser

@kdy1 kdy1 merged commit c0602c8 into swc-project:main Jun 25, 2024
149 checks passed
@kdy1 kdy1 deleted the perf-parser branch June 25, 2024 13:38
@kdy1 kdy1 changed the title perf(es/parser): Add a check before performing numeric operations perf(es/parser): Add a check before numeric operations Jun 25, 2024
@kdy1 kdy1 modified the milestones: Planned, v1.6.6 Jun 29, 2024
@swc-project swc-project locked as resolved and limited conversation to collaborators Jul 29, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

@magic-akari magic-akari magic-akari approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.6.6
Development

Successfully merging this pull request may close these issues.
2 participants
@kdy1 @magic-akari