Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/minifier): Fix if_return bug related to await and yield #8328

Merged
merged 7 commits into from
Nov 23, 2023
Merged

fix(es/minifier): Fix if_return bug related to await and yield #8328

merged 7 commits into from
Nov 23, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Nov 22, 2023

Description:

Related issue:

@kdy1 kdy1 added this to the Planned milestone Nov 22, 2023
@kdy1 kdy1 self-assigned this Nov 22, 2023
@kdy1 kdy1 changed the title fix(es/minifier): Fix a bug fix(es/minifier): Fix if_return bug related to await and yield Nov 22, 2023
kdy1
kdy1 commented Nov 22, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 marked this pull request as ready for review November 22, 2023 06:46
@kdy1 kdy1 requested a review from a team as a code owner November 22, 2023 06:46
@kdy1 kdy1 requested a review from Austaras November 22, 2023 23:43
@kdy1 kdy1 requested a review from Austaras November 22, 2023 23:53
@kdy1 kdy1 enabled auto-merge (squash) November 22, 2023 23:59
swc-bot
swc-bot reviewed Nov 23, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment •
edited by kdy1
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 01e2c7f into swc-project:main Nov 23, 2023
@kdy1 kdy1 deleted the issue-8324 branch November 23, 2023 00:54
@Austaras Austaras mentioned this pull request Nov 25, 2023
Merged
kdy1 pushed a commit that referenced this pull request Nov 25, 2023
@Austaras
fix(es/minifier): Give up terminate merge if in try with finally (#…
ed5a9b3 
…8342)

**Related issue:**

 - Closes #8337.
 - Closes #8324.
 - Reverts #8328.
@kdy1 kdy1 modified the milestones: Planned, v1.3.100 Nov 30, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@Austaras Austaras Austaras approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.100
Development

Successfully merging this pull request may close these issues.

Unintended compressed with if_return flag
3 participants
@kdy1 @Austaras @swc-bot