Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/parser): Report error for exported reserved name #8313

Merged
merged 6 commits into from
Nov 20, 2023
Merged

fix(es/parser): Report error for exported reserved name #8313

merged 6 commits into from
Nov 20, 2023
+89 −14

Conversation

magic-akari
Copy link
Member

@magic-akari magic-akari commented Nov 19, 2023 •
edited by kdy1
Loading

@magic-akari magic-akari marked this pull request as ready for review November 19, 2023 16:10
@magic-akari magic-akari requested a review from a team as a code owner November 19, 2023 16:10
@kdy1 kdy1 added this to the Planned milestone Nov 20, 2023
kdy1
kdy1 requested changes Nov 20, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

swc-bump:

  • swc_ecma_parser

crates/swc_ecma_parser/src/parser/stmt/module_item.rs Outdated Show resolved Hide resolved
crates/swc_ecma_parser/src/parser/stmt/module_item.rs Outdated Show resolved Hide resolved
kdy1
kdy1 approved these changes Nov 20, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@kdy1 kdy1 enabled auto-merge (squash) November 20, 2023 04:47
@kdy1 kdy1 merged commit feb8a6d into swc-project:main Nov 20, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.98 Nov 20, 2023
@magic-akari magic-akari deleted the fix/issue-8268 branch December 5, 2023 03:12
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kdy1 kdy1 kdy1 approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
v1.3.99
Development

Successfully merging this pull request may close these issues.

passing export { default } to the parser should throw an error
2 participants
@magic-akari @kdy1