Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(es/minifier): Swap bin expr to save paren #8277

Merged
merged 2 commits into from
Nov 14, 2023
Merged

feat(es/minifier): Swap bin expr to save paren #8277

merged 2 commits into from
Nov 14, 2023

Conversation

Austaras
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@kdy1 kdy1 self-assigned this Nov 13, 2023
@kdy1 kdy1 added this to the Planned milestone Nov 13, 2023
@kdy1
Copy link
Member

kdy1 commented Nov 13, 2023

I think we need a way to verify this without publishing...
It would be nice if there were some vendors helping us testing swc

@Austaras
Copy link
Member Author

I believe this is generally fine. Both terser and gcc has similar feature.

kdy1
kdy1 approved these changes Nov 14, 2023
View reviewed changes
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_minifier

@kdy1 kdy1 enabled auto-merge (squash) November 14, 2023 16:00
@swc-bot swc-bot requested a review from a team as a code owner November 14, 2023 16:02
swc-bot
swc-bot reviewed Nov 14, 2023
View reviewed changes
Copy link
Collaborator

@swc-bot swc-bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Automated review comment generated by auto-rebase script

@kdy1 kdy1 merged commit 65c3d0e into swc-project:main Nov 14, 2023
@kdy1 kdy1 modified the milestones: Planned, v1.3.98 Nov 21, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Dec 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@swc-bot swc-bot swc-bot left review comments

@magic-akari magic-akari magic-akari approved these changes

@kdy1 kdy1 kdy1 approved these changes

@jridgewell jridgewell Awaiting requested review from jridgewell

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.99
Development

Successfully merging this pull request may close these issues.
4 participants
@Austaras @kdy1 @magic-akari @swc-bot