Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(es/decorators): Minimize class declarations transformation #8245

Merged
merged 6 commits into from
Nov 10, 2023

Conversation

magic-akari
Copy link
Member

Description:

BREAKING CHANGE:

Related issue (if exists):

@magic-akari magic-akari marked this pull request as ready for review November 9, 2023 01:16
@kdy1 kdy1 self-assigned this Nov 9, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we should check if the mutability of the variable (let/class) is identical, and if not we should add an assumption entry.

I'll check it using chrome

@kdy1
Copy link
Member

kdy1 commented Nov 10, 2023

These are not affected

class Foo {
    static {
         Foo = 1;
    }

}
let Foo = class Foo {
    static {
         Foo = 1;
    }

}
class Foo {
    static field = Foo = 1;

}
let Foo = class Foo {
    static field = Foo = 1;

}

kdy1
kdy1 previously approved these changes Nov 10, 2023
Copy link
Member

@kdy1 kdy1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!


swc-bump:

  • swc_ecma_transforms_proposal
  • swc_ecma_transforms_typescript

@kdy1 kdy1 added this to the Planned milestone Nov 10, 2023
@kdy1
Copy link
Member

kdy1 commented Nov 10, 2023

Oops there's a merge conflict

@kdy1 kdy1 enabled auto-merge (squash) November 10, 2023 01:45
@magic-akari
Copy link
Member Author

There are some broken snapshots introduced in #8257.

@kdy1
Copy link
Member

kdy1 commented Nov 10, 2023

Can you update them too?

@kdy1
Copy link
Member

kdy1 commented Nov 10, 2023

Ok action of CI is bit broken, but not sure about the reason

@kdy1 kdy1 merged commit 6992d83 into swc-project:main Nov 10, 2023
@kdy1
Copy link
Member

kdy1 commented Nov 10, 2023

🤣 CI is so broken so it passed again

@kdy1 kdy1 modified the milestones: Planned, v1.3.98 Nov 21, 2023
@magic-akari magic-akari deleted the es/decorators branch December 5, 2023 03:13
@swc-project swc-project locked as resolved and limited conversation to collaborators Jan 4, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants