-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(es/decorators): Minimize class declarations transformation #8245
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should check if the mutability of the variable (let/class) is identical, and if not we should add an assumption entry.
I'll check it using chrome
These are not affected class Foo {
static {
Foo = 1;
}
} let Foo = class Foo {
static {
Foo = 1;
}
} class Foo {
static field = Foo = 1;
} let Foo = class Foo {
static field = Foo = 1;
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
swc-bump:
- swc_ecma_transforms_proposal
- swc_ecma_transforms_typescript
Oops there's a merge conflict |
There are some broken snapshots introduced in #8257. |
Can you update them too? |
|
🤣 CI is so broken so it passed again |
Description:
BREAKING CHANGE:
Related issue (if exists):