perf(atoms): Introduce AtomStoreCell
#8232
Merged
+44
−33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
reviewed
Nov 7, 2023
Comment on lines
32
to
33
| // SAFETY: We can skip the borrow check of RefCell because | ||
| // this API enforces a safe contract. It is slightly faster |
There was a problem hiding this comment.
I think this comment is wrong.
It's safe because of the way we use from the parser, not because of API.
There was a problem hiding this comment.
Is it possible to use the current API of AtomStoreCell in an unsafe way? (With respect to an UnsafeCell vs RefCell. I'm not sure what's going on internally in AtomStore and Atom)
There was a problem hiding this comment.
Ah you are right. The mutable borrow ends in the function.
Can you add this to the comment?
There was a problem hiding this comment.
Sure, I will do it in the morning here.
|
Maybe we can move this to |
kdy1
changed the title
AtomStoreCellAtomStoreCell
kdy1
changed the title
AtomStoreCellAtomStoreCell
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduces an
AtomStoreCelltype which internally uses anUnsafeCell, but enforces a safe contract. This allows skipping the borrow check ofRefCell.> cargo "bench" "--package" "swc_ecma_parser" "--bench" "parser" "--" "three"Main: ~37.8ms
This PR: ~37.4ms