fix(css/modules): Fix handling of :global() selector
#8219
Merged
+62
−22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kdy1
commented
Nov 4, 2023
| @@ -0,0 +1,3 @@ | |||
| .__local__a.b.d .__local__a.c.d { | |||
There was a problem hiding this comment.
@JSerFeng What's the expected output?
The playground link you posted says
.EgL3uq_a.b .c.EgL3uq_d{color:red}but I'm not sure if it's correct.
There was a problem hiding this comment.
I think lightningcss is right, postcss is the same with lightningcss
kdy1
changed the title
global selector:global() selector
![kodiakhq[bot]](https://avatars.githubusercontent.com/in/29196?s=60&v=4){kind=small}
swc-bot
reviewed
Nov 4, 2023
JSerFeng
approved these changes
Nov 5, 2023
|
Thanks ! |
swc-bot
reviewed
Nov 5, 2023
swc-bot
reviewed
Nov 6, 2023
This was referenced Dec 6, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related issue: