Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(es/decorators): Fix a regression about class expressions #8102

Merged
merged 17 commits into from
Oct 11, 2023
Merged

fix(es/decorators): Fix a regression about class expressions #8102

merged 17 commits into from
Oct 11, 2023

Conversation

kdy1
Copy link
Member

@kdy1 kdy1 commented Oct 11, 2023

@kdy1 kdy1 added this to the Planned milestone Oct 11, 2023
@kdy1 kdy1 self-assigned this Oct 11, 2023
@kdy1 kdy1 marked this pull request as ready for review October 11, 2023 13:48
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 11, 2023
View reviewed changes
kdy1
kdy1 commented Oct 11, 2023
View reviewed changes
Copy link
Member Author

@kdy1 kdy1 left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

swc-bump:

  • swc_ecma_transforms_proposal

@kdy1 kdy1 enabled auto-merge (squash) October 11, 2023 13:49
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 11, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 11, 2023
View reviewed changes
kodiakhq[bot]
kodiakhq bot previously approved these changes Oct 11, 2023
View reviewed changes
kdy1
kdy1 commented Oct 11, 2023
View reviewed changes
crates/swc/tests/fixture/issues-5xxx/5626/output/index.ts
_ts_decorate([
Prop(),
_ts_metadata("design:type", typeof BigInt === "undefined" ? Object : BigInt)
], Example.prototype, "prop", void 0);
export { Example as default };
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a bugfix

crates/swc/tests/fixture/issues-4xxx/4063/1/output/index.ts
@@ -17,13 +17,14 @@ define([
function state() {}
class Controller {
}
class _class extends Controller {
var _class;
_class = class _$class extends Controller {
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minifier will be able to merge these, so I think this change is fine.

@kdy1 kdy1 merged commit cb4361f into swc-project:main Oct 11, 2023
@kdy1 kdy1 deleted the issue-8095 branch October 11, 2023 16:45
@kdy1 kdy1 modified the milestones: Planned, v1.3.93 Oct 13, 2023
@swc-project swc-project locked as resolved and limited conversation to collaborators Nov 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kodiakhq kodiakhq[bot] kodiakhq[bot] approved these changes

Assignees

@kdy1 kdy1

Labels
None yet
Milestone
v1.3.93
Development

Successfully merging this pull request may close these issues.

Anonymous class TS method decorator broken
1 participant
@kdy1