feat(es): Introduce runPluginFirst for Wasm plugins (#9645)

**Related issue:** - Closes #9132
swc-project · Oct 15, 2024 · 3d3e434 · 3d3e434
1 parent 8a19201
commit 3d3e434
Show file tree

Hide file tree

Showing 2 changed files with 36 additions and 12 deletions.
diff --git a/crates/swc/src/config/mod.rs b/crates/swc/src/config/mod.rs
@@ -582,7 +582,7 @@ impl Options {
         let disable_all_lints = experimental.disable_all_lints.into_bool();
 
         #[cfg(feature = "plugin")]
-        let plugin_transforms = {
+        let plugin_transforms: Box<dyn Fold> = {
             let transform_filename = match base {
                 FileName::Real(path) => path.as_os_str().to_str().map(String::from),
                 FileName::Custom(filename) => Some(filename.to_owned()),
@@ -643,13 +643,13 @@ impl Options {
                     }
                 }
 
-                crate::plugin::plugins(
+                Box::new(crate::plugin::plugins(
                     experimental.plugins,
                     transform_metadata_context,
                     comments.cloned(),
                     cm.clone(),
                     unresolved_mark,
-                )
+                ))
             }
 
             // Native runtime plugin target, based on assumption we have
@@ -663,26 +663,28 @@ impl Options {
                      skipped. Refer https://github.com/swc-project/swc/issues/3934 for the details.",
                 );
 
-                noop()
+                Box::new(noop())
             }
         };
 
         #[cfg(not(feature = "plugin"))]
-        let plugin_transforms = {
+        let plugin_transforms: Box<dyn Fold> = {
             if experimental.plugins.is_some() {
                 handler.warn(
                     "Plugin is not supported with current @swc/core. Plugin transform will be \
                      skipped.",
                 );
             }
-            noop()
+            Box::new(noop())
         };
 
+        let mut plugin_transforms = Some(plugin_transforms);
+
         let pass: Box<dyn Fold> = if experimental
             .disable_builtin_transforms_for_internal_testing
             .into_bool()
         {
-            Box::new(plugin_transforms)
+            plugin_transforms.unwrap()
         } else {
             let decorator_pass: Box<dyn Fold> =
                 match transform.decorator_version.unwrap_or_default() {
@@ -698,6 +700,11 @@ impl Options {
                 };
 
             Box::new(chain!(
+                if experimental.run_plugin_first.into_bool() {
+                    option_pass(plugin_transforms.take())
+                } else {
+                    Box::new(noop())
+                },
                 Optional::new(
                     lint_to_fold(swc_ecma_lints::rules::all(LintParams {
                         program: &program,
@@ -748,7 +755,7 @@ impl Options {
                     ),
                     syntax.typescript()
                 ),
-                plugin_transforms,
+                option_pass(plugin_transforms.take()),
                 custom_before_pass(&program),
                 // handle jsx
                 Optional::new(
@@ -1225,6 +1232,9 @@ pub struct JscExperimental {
     #[serde(default)]
     pub cache_root: Option<String>,
 
+    #[serde(default)]
+    pub run_plugin_first: BoolConfig<false>,
+
     #[serde(default)]
     pub disable_builtin_transforms_for_internal_testing: BoolConfig<false>,
 
@@ -1751,3 +1761,10 @@ fn build_resolver(
 
     r
 }
+
+fn option_pass(pass: Option<Box<dyn Fold>>) -> Box<dyn Fold> {
+    match pass {
+        None => Box::new(noop()),
+        Some(pass) => pass,
+    }
+}
diff --git a/packages/types/index.ts b/packages/types/index.ts
@@ -305,7 +305,7 @@ export interface TerserMangleOptions {
     /**
      * Pass `true` to mangle names declared in the top level scope.
      */
-    topLevel?: boolean
+    topLevel?: boolean;
 
     /**
      * @deprecated An alias for compatibility with terser.
@@ -349,7 +349,7 @@ export interface TerserMangleOptions {
     reserved?: string[];
 }
 
-export interface TerserManglePropertiesOptions { }
+export interface TerserManglePropertiesOptions {}
 
 /**
  * Programmatic options.
@@ -662,6 +662,13 @@ export interface JscConfig {
          */
         plugins?: Array<[string, Record<string, any>]>;
 
+        /**
+         * Run Wasm plugins before stripping TypeScript or decorators.
+         *
+         * See https://github.com/swc-project/swc/issues/9132 for more details.
+         */
+        runPluginFirst?: boolean;
+
         /**
          * Disable builtin transforms. If enabled, only Wasm plugins are used.
          */
@@ -1159,7 +1166,7 @@ export interface Output {
     map?: string;
 }
 
-export interface MatchPattern { }
+export interface MatchPattern {}
 
 // -------------------------------
 // ---------- Ast nodes ----------
@@ -1391,7 +1398,7 @@ export type Expression =
     | OptionalChainingExpression
     | Invalid;
 
-interface ExpressionBase extends Node, HasSpan { }
+interface ExpressionBase extends Node, HasSpan {}
 
 export interface Identifier extends ExpressionBase {
     type: "Identifier";