Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(sourcemap-support): add "tslib" as a dependnecy for "sourcemap-suport" #670

Merged
merged 1 commit into from
Oct 4, 2022

Conversation

maxkomarychev
Copy link
Contributor

@maxkomarychev maxkomarychev commented Oct 3, 2022

Compiled code of this package requires "tslib" to be installed which is not the case if the porject has "@swc-node/register" as a single dependency.

In that case npm will generate the following tree:

- node_modules
  - @swc-node
    - sourcemap-support
    - register
      - node_modules
        - tslib

and tslib will be insaccessible for "@swc-node/sourcemap-support"

@CLAassistant
Copy link

CLAassistant commented Oct 3, 2022

CLA assistant check
All committers have signed the CLA.

Compiled code of this package requires "tslib" to be installed
which is not the case if the porject has "@swc-node/register"
as a single dependency.

In that case `npm` will generate the following tree:

```
- node_modules
  - @swc-node
    - sourcemap-support
    - register
      - node_modules
        - tslib
```

and `tslib` will be insaccessible for "@swc-node/sourcemap-support"
@Brooooooklyn Brooooooklyn changed the title Add "tslib" as a dependnecy for "sourcemap-suport" fix(sourcemap-support): add "tslib" as a dependnecy for "sourcemap-suport" Oct 4, 2022
@Brooooooklyn Brooooooklyn merged commit ec9ffeb into swc-project:master Oct 4, 2022
@maxkomarychev
Copy link
Contributor Author

thanks :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

3 participants