This repository has been archived by the owner on Nov 1, 2021. It is now read-only.
backend/drm: add WLR_DRM_NO_ATOMIC_GAMMA env variable #1344
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows the legacy interface to be used instead of atomic if needed. This is a workaround to make some Intel GPUs work (if this variable is unset) as well as to make some AMD GPUs work (if this variable is set).
martinetd
approved these changes
Oct 28, 2018
| // (can happen on older Intel GPUs that support gamma but not degamma). | ||
| // TEMP: This is broken on AMDGPU. Provide a fallback to legacy until they | ||
| // get it fixed. Ref https://bugs.freedesktop.org/show_bug.cgi?id=107459 | ||
| const char *no_atomic_str = getenv("WLR_DRM_NO_ATOMIC_GAMMA"); |
There was a problem hiding this comment.
I actually looked at this and was wondering about doing a getenv everytime we set gamma.. It's not a fast path but it's the first getenv we'll have that's not at init.
Well, I guess it's probably ok
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows the legacy interface to be used instead of atomic if needed. This
is a workaround to make some Intel GPUs work (if this variable is unset) as
well as to make some AMD GPUs work (if this variable is set).
See swaywm/sway#2700