-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Config output id doesn't match swaybg #7172
Comments
Hm, right. The root cause is that swaybg uses a hack to match output identifiers: https://github.com/swaywm/swaybg/blob/c9608982d2a8bf0e70291a7a1b8cade1ca06f36f/main.c#L303 |
Duplicate of swaywm/swaybg#44 |
If we were to ignore backwards compatibility entirely, one way to fix this would be make Sway adopt the wlroots output description value for its output identifiers everywhere. (That is, the value which swaybg receives through the wl_output::description event) See for example the following patch 0001-Use-the-wlroots-wl_output-description-as-output-iden.patch.txt. There probably is a better solution that I haven't thought of, so I'm not planning on making a PR out of the patch myself. |
I'd prefer not to rely on the output description, because this makes swaybg incompatible with any compositor which uses a different format (either non-wlroots, or a wlroots compositor which sets a custom output description). More discussions: |
Please fill out the following:
Sway Version: 1c368fb
Configuration File:
Handle NULL output make/model/serial #7031 changed the output description that's used to match config sections, but didn't update the
wl_output::description
that's used inswaybg
. This causes a mismatch between these settings, causing the bg not to show in some cases.The text was updated successfully, but these errors were encountered: