-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move examples to data-files section #2189
base: main
Are you sure you want to change the base?
Conversation
Otherwise, change to example would cause recompilation.
swarm.cabal
Outdated
@@ -61,6 +60,7 @@ data-files: | |||
test/standalone-topography/*.png | |||
test/standalone-topography/*.yaml | |||
worlds/*.world | |||
example/*.sw |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ah, I guess we have it in extra-source-files
because it is not in data directory?
Maybe we could workaround it by a symlink? EDIT: Or by inlining datadir
to others as I did.
Can you explain in more detail? I'm not sure I understand the problem we're trying to solve here. |
@byorgey, if you want to iterate on a swarm file in the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Seems fine to me. I think data-files
get installed in a special location when cabal install
runs, which is irrelevant for example
, but I don't think it matters that much.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmm, actually, now I am not so sure. I think the reason the tests are failing is that they are looking for the example
directory---which isn't there because only things listed in extra-source-files
get unpacked into the source tree when building + running tests. That also means if someone does cabal get
they will no longer get the example
directory. extra-source-files
actually seems like the right place for it.
Otherwise, change to example would cause recompilation.