Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enhancement: models from a package whose name conflicts with other packages #1373

Closed
sdghchj opened this issue Oct 31, 2022 · 1 comment
Closed

Comments

@sdghchj
Copy link
Member

sdghchj commented Oct 31, 2022

UPD:
But if i have smth like this in imports

"ordering/internal/gateways/http/presenters/api/products/v1/create"
_ "ordering/internal/gateways/http/views/api/products/v1/create" // here is JsonApiAttributesV1

It failes with message ParseComment error in file ordering\application\internal\gateways\http\controllers\api\products\v1\create.go :cannot find type definition: create.JsonApiAttributesV1

Originally posted by @doublebigguy in #1353 (comment)

@sdghchj
Copy link
Member Author

sdghchj commented Oct 31, 2022

Enhancements:

  1. search imports sequencely, till find the type.
  2. consider every import mode ,such as alias,_, .
  3. a model imported from an external by mode .

View details in the testdata

@sdghchj sdghchj changed the title models from a package whose name conflicts with other packages enhancement: models from a package whose name conflicts with other packages Oct 31, 2022
@sdghchj sdghchj closed this as completed Nov 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant