-
Notifications
You must be signed in to change notification settings - Fork 9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Validator badge is always enabled and can't be disabled #2761
Labels
Comments
It was quite useful to set a value of |
The ability to remove the validator is a missing feature. It will be addressed shortly |
This was referenced Mar 27, 2017
fixed with 0b668cc |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Previously validator badge was hidden if the false value (
null
,false
) was explicitly provided asvalidatorUrl
, or if the spec was being loaded from localhost: https://github.com/swagger-api/swagger-ui/blob/2.x/src/main/javascript/view/MainView.js#L57-L65New validator badge component always uses the default url if
validatorUrl
value is not truthy:swagger-ui/src/core/components/online-validator-badge.jsx
Line 10 in 33e5775
I think the default validatorUrl should only be used if the value is
undefined
, that is, when no explicit value is not set. Hiding the validator when spec is served from localhost is also good idea, as validating that going to fail always.The text was updated successfully, but these errors were encountered: