Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Swift] Argument separation broken #9085

Closed
bsteimer opened this issue Jan 18, 2019 · 1 comment
Closed

[Swift] Argument separation broken #9085

bsteimer opened this issue Jan 18, 2019 · 1 comment

Comments

@bsteimer
Copy link

Description

Generating Swift API leads to sometimes not separated method arguments

    /**
     Updated user
     - parameter body: (body) Updated user object      - parameter username: (path) name that need to be updated 
     - parameter completion: completion handler to receive the data and the error objects
     */
    open class func updateUser(body: Userusername: String, completion: @escaping ((_ data: Void?,_ error: Error?) -> Void)) {
        updateUserWithRequestBuilder(body: bodyusername: username).execute { (response, error) -> Void in
            if error == nil {
                completion((), error)
            } else {
                completion(nil, error)
            }
        }
    }
Swagger-codegen version

First introduced with 3.0.3, also noticed in 3.0.4

Swagger declaration file content or url

https://petstore.swagger.io/v2/swagger.json

Command line used for generation

Used swagger-codegen-maven-plugin

<plugin>
    <groupId>io.swagger.codegen.v3</groupId>
    <artifactId>swagger-codegen-maven-plugin</artifactId>
    <version>3.0.4</version>
    <executions>
        <execution>
            <goals>
                <goal>generate</goal>
            </goals>
            <configuration>
                <inputSpec>swagger.yaml</inputSpec>
                <language>swift4</language>
            </configuration>
        </execution>
    </executions>
</plugin>
Steps to reproduce
Related issues/PRs
Suggest a fix/enhancement
@HugoMario
Copy link
Contributor

hello @bsteimer this issue has been fixed by codegen-generators 299 PR. So going to close this issue but, please let me know if you find something wrong and i'll work on a fix asap

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants