Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TypeScript] Use only typings in petstore sample #2013

Open
cbornet opened this issue Feb 1, 2016 · 7 comments
Open

[TypeScript] Use only typings in petstore sample #2013

cbornet opened this issue Feb 1, 2016 · 7 comments

Comments

@cbornet
Copy link
Contributor

cbornet commented Feb 1, 2016

As TSD is deprecated : see DefinitelyTyped/tsd#269

@wing328
Copy link
Contributor

wing328 commented Mar 19, 2016

@cbornet would you have cycle to contribute a PR to update that?

@cbornet
Copy link
Contributor Author

cbornet commented Jun 2, 2016

@Vrolijkx it seems still present in typescript-angular sample. Would you have a look ?

@wing328 wing328 modified the milestones: v2.3.0, v2.2.0 Jul 13, 2016
@wing328 wing328 modified the milestones: v2.2.1, v2.2.2 Aug 8, 2016
@kenisteward
Copy link
Contributor

The current new way to import types is now to use @types scope on npm instead of typings as of TypeScript 2.0 https://blogs.msdn.microsoft.com/typescript/2016/06/15/the-future-of-declaration-files/. If types are needed the clients should be updated to use this.

@wing328 wing328 modified the milestones: Future, v2.2.2 Feb 6, 2017
@wing328
Copy link
Contributor

wing328 commented Feb 6, 2017

@kenisteward thanks for the sharing the link. Let me know if you've time to contribute the enhancement using @types

@Vrolijkx
Copy link
Contributor

Vrolijkx commented Feb 8, 2017

@cbornet I think it's better to go directly to the @types like @kenisteward suggests

@kenisteward
Copy link
Contributor

My only thing is it breaks some things possibly because I think there is a UMD discrepancy

@cbornet
Copy link
Contributor Author

cbornet commented Feb 8, 2017

@Vrolijkx agreed. Maybe close this issue and open a new one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants