-
Notifications
You must be signed in to change notification settings - Fork 6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[RUBY] Replace deprecated URI.encode
to support ruby 2.7 without warnings
#10445
Conversation
Tests are failing due to un unrelated change in Typhoeus: typhoeus/typhoeus#575 An option would be to change that check, or another one, to call Thoughts? |
Pushed the second option to have the test passing. Let me know if you'd prefer an alternative, or a separate PR. |
Thanks a lot for PR @kitop!! Here is fine :) |
PR checklist
./bin/
to update Petstore sample so that CIs can verify the change. (For instance, only need to run./bin/{LANG}-petstore.sh
and./bin/security/{LANG}-petstore.sh
if updating the {LANG} (e.g. php, ruby, python, etc) code generator or {LANG} client's mustache templates). Windows batch files can be found in.\bin\windows\
.3.0.0
branch for changes related to OpenAPI spec 3.0. Default:master
.Description of the PR
Issue: #10444
Ruby's URI.encode has been deprecated over 10 years ago. In addition, Ruby 2.7 now shows the warning in non-verbose mode, resulting in very noisy logs.
This tackles the problem via the second solution proposed in the issue.
It adds a dependency on the addressable gem, and uses Addressable::URI.encode which is part-aware.
Already tried this in a generated library with success: https://github.com/netlify/zuora-ruby-client/pull/7/files
/cc @zlx