Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Converting Pre-Release to Release #64

Open
pranjal-joshi opened this issue Feb 6, 2022 · 2 comments
Open

Converting Pre-Release to Release #64

pranjal-joshi opened this issue Feb 6, 2022 · 2 comments

Comments

@pranjal-joshi
Copy link
Contributor

Hello,
I have a matrix job that builds executables for multiple platforms.

I want to upload binaries to the same pre-release and then publish the release only if all matrix jobs pass the test.

Need guidance for creating a pre-release first and then publishing the same in the next job if tests are passed.

Existing workflow is here - https://github.com/pranjal-joshi/Screeni-py/blob/c2899ab1097802ee2b7c91078a4c197c98377f79/.github/workflows/workflow-build-matrix.yml#L133

@shawaj
Copy link
Contributor

shawaj commented Jan 22, 2023

You could just do it with four separate jobs in the same action, one for each of the matrix builds and the final one for the upload release action.

And just use a needs, similar to:
https://github.com/NebraLtd/hm-pyhelper/blob/ced0a994551e0a360798a19fb4d7f3620e4bd454/.github/workflows/test.yml#L49

Or maybe you could use something like this as well:
https://github.com/lewagon/wait-on-check-action

@svenstaro
Copy link
Owner

This should be done as of #74. Please check whether that suits your needs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants