Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Transliteration of all-caps strings #1102

Closed
padde opened this issue Aug 30, 2023 · 2 comments
Closed

Transliteration of all-caps strings #1102

padde opened this issue Aug 30, 2023 · 2 comments

Comments

@padde
Copy link
Contributor

padde commented Aug 30, 2023

I just noticed an edge case for transliteration of capital letters in general. There is no handling of all-caps situations. Consider the following German examples:

# capital sharp s only appears in all-caps so not a problem
I18n.transliterate("FUẞBALL")
#=> "FUSSBALL"

# umlauts currently handled only at beginning of a normally spelled noun correctly
I18n.transliterate("Ästhetik")
#=> "Aesthetik"

# however for all caps words it does produce a mixed case result:
I18n.transliterate("KANÜLE")
#=> "KANUeLE"

Of course there are more edge cases, like how do we handle single letter strings (I suggest they are basically also all caps, so should produce all caps transliterated).

Any thoughts on this? Should I dive into an implementation of this? Is this a general problem with all languages that needs more careful consideration?

@pama
Copy link
Collaborator

pama commented Aug 30, 2023

Hi @padde, the transliterate function is part of the Ruby i18n gem. I recommend opening an issue directly in their repository.

@pama pama closed this as completed Aug 30, 2023
@padde
Copy link
Contributor Author

padde commented Aug 30, 2023

@pama thanks, of course you are right!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants