Remove deprecated a11y-no-onchange warning #6457
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes the
a11y-no-onchange
compiler warning. See #4946 (comment) for the rationale behind this change. tl;dr: the jsx-a11y rule this warning was based on is now deprecated. The original rationale is from 2004 and no longer an a11y best practice for modern browsers (or even IE11).My comment on the original issue thread received 20+ positive reactions since I posted it in January, so figured I'd submit a PR to get the ball rolling. If this change is not wanted, feel free to close.
Fixes #4946
Before submitting the PR, please make sure you do the following
Tests
npm test
and lint the project withnpm run lint