Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrage Svelte from v5.14.1 to v5.14.4 breaks deployment to Cloudlfare Workers #14759

Closed
Perdolique opened this issue Dec 18, 2024 · 1 comment · Fixed by #14765
Closed

Upgrage Svelte from v5.14.1 to v5.14.4 breaks deployment to Cloudlfare Workers #14759

Perdolique opened this issue Dec 18, 2024 · 1 comment · Fixed by #14765

Comments

@Perdolique
Copy link

Describe the bug

I upgraded path version of Svelte and got the following error during deployment to Cloudflare Workers:

21:47:50.861 | npm ERR! code EBADENGINE
21:47:50.863 | npm ERR! engine Unsupported engine
21:47:50.863 | npm ERR! engine Not compatible with your version of node/npm: @typescript-eslint/[email protected]
21:47:50.863 | npm ERR! notsup Not compatible with your version of node/npm: @typescript-eslint/[email protected]
21:47:50.864 | npm ERR! notsup Required: {"node":"^18.18.0 || ^20.9.0 || >=21.1.0"}
21:47:50.864 | npm ERR! notsup Actual:   {"npm":"9.6.7","node":"v18.17.1"}

I guess it's because @typescript-eslint/types was added in v5.14.3 through new esrap dependency.

[email protected]
└─┬ [email protected]
  └── @typescript-eslint/[email protected]

Reproduction

I've just upgraded Svelte to patch version and nothing else.

Logs

No response

System Info

System:
    OS: Linux 5.15 Ubuntu 22.04.4 LTS 22.04.4 LTS (Jammy Jellyfish)
    CPU: (16) x64 AMD Ryzen 7 3700X 8-Core Processor
    Memory: 12.50 GB / 15.58 GB
    Container: Yes
    Shell: 5.8.1 - /usr/bin/zsh
  Binaries:
    Node: 23.3.0 - /run/user/1000/fnm_multishells/9366_1734546699967/bin/node
    npm: 10.9.1 - /run/user/1000/fnm_multishells/9366_1734546699967/bin/npm
    bun: 1.1.17 - ~/.bun/bin/bun
  npmPackages:
    svelte: ^5.14.4 => 5.14.4

Severity

blocking an upgrade

@paoloricciuti
Copy link
Member

Uh that should be a devdep instead of a dependency...will either open a PR to esrap or ask rich to fix it lol

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants