Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lowercase hash links? #556

Closed
benmccann opened this issue Oct 22, 2024 · 1 comment · Fixed by #586
Closed

lowercase hash links? #556

benmccann opened this issue Oct 22, 2024 · 1 comment · Fixed by #586

Comments

@benmccann
Copy link
Member

benmccann commented Oct 22, 2024

https://svelte.dev/docs/kit/types#generated-types turned into https://svelte.dev/docs/kit/types#Generated-types, which I think both looks worse and is unnecessarily breaking

Though it's a bit nicer here: https://svelte.dev/docs/kit/$app-navigation#pushState. So I think I'd lowercase only for titles and not for hashes generated from reference docs if possible

What we decide here may affect sveltejs/kit#12862

@benmccann
Copy link
Member Author

I think the way to do this might be to put code references in backticks when they are in the headings. We could then lowercase everything that is not in backticks. We shouldn't change the styling for backticks in headings though

This was referenced Oct 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant