Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

sapper export --legacy breaks pdf static serving #572

Closed
sgametrio opened this issue Feb 20, 2019 · 2 comments · Fixed by #785
Closed

sapper export --legacy breaks pdf static serving #572

sgametrio opened this issue Feb 20, 2019 · 2 comments · Fixed by #785

Comments

@sgametrio
Copy link

I have not tried yet if export breaks other types of file
Version: sapper 0.26.0-alpha-8

How to reproduce

  1. Put some pdf file in static folder.
  2. Reference them in your application so that sapper export --legacy creates routes for them
  3. Try navigating to them. (pdf error or pdf blank)

Solution

After running export replace pdf in __sapper__/export with files in your static folder
@arggh
Copy link

arggh commented Feb 23, 2019

I can confirm this issue is very real, glad I noticed it before things went south!

@cristovao-trevisan cristovao-trevisan mentioned this issue Jul 3, 2019
Merged
@rof20004
Copy link

I confirm this issue too.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fixing linked static binary file corruption cristovao-trevisan/sapper
3 participants
@rof20004 @sgametrio @arggh