Skip to content
This repository has been archived by the owner on Jan 11, 2023. It is now read-only.

RollupResult.to_json corrupts images #1245

Closed
benmccann opened this issue Jun 1, 2020 · 1 comment · Fixed by #1246
Closed

RollupResult.to_json corrupts images #1245

benmccann opened this issue Jun 1, 2020 · 1 comment · Fixed by #1246

Comments

@benmccann
Copy link
Member

benmccann commented Jun 1, 2020

Took me awhile to figure out that a method called to_json would be doing this until I opened it up:

// TODO extract_css has side-effects that don't belong

Something bad is happening here:

fs.readdirSync(asset_dir).forEach(file => {

It appears to be overwriting my images. We should probably add a filter to make it operate only on .js files

@Conduitry
Copy link
Member

Fixed in 0.27.14.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants