Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set form to null before updating it with real values #9267

Merged
merged 2 commits into from
Mar 2, 2023
Merged

set form to null before updating it with real values #9267

merged 2 commits into from
Mar 2, 2023

Conversation

Rich-Harris
Copy link
Member

@Rich-Harris Rich-Harris commented Mar 1, 2023 •
edited
Loading

fixes #8513

Please don't delete this checklist! Before submitting the PR, please make sure you do the following:

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.

Tests

  • Run the tests with pnpm test and lint the project with pnpm lint and pnpm check

Changesets

  • If your PR makes a change that should be noted in one or more packages' changelogs, generate a changeset by running pnpm changeset and following the prompts. Changesets that add features should be minor and those that fix bugs should be patch. Please prefix changeset messages with feat:, fix:, or chore:.

@Rich-Harris Rich-Harris marked this pull request as ready for review March 1, 2023 18:13
elliott-with-the-longest-name-on-github
elliott-with-the-longest-name-on-github approved these changes Mar 2, 2023
View reviewed changes
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, nice

@Rich-Harris Rich-Harris merged commit 744dc81 into master Mar 2, 2023
@Rich-Harris Rich-Harris deleted the gh-8513 branch March 2, 2023 19:52
@github-actions github-actions bot mentioned this pull request Mar 2, 2023
Merged
@eltigerchino eltigerchino mentioned this pull request Mar 20, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github elliott-with-the-longest-name-on-github approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

use:enhance resets form even if form.x values used for populating it
2 participants
@Rich-Harris @elliott-with-the-longest-name-on-github