Route level config alt #8863
Merged
Route level config alt #8863
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dummdidumm
reviewed
Feb 2, 2023
| /** `true` if one or more routes have `export const config = ..` in it */ | ||
| hasRouteLevelConfig: boolean; | ||
| /** An array of dynamic (not prerendered) routes */ | ||
| routes: RouteDefinition[]; |
There was a problem hiding this comment.
Note for later: The Vercel adapter needs a major version bump because the peer dependency on kit needs a bump so it can expect this API to be present.
There was a problem hiding this comment.
Adapter-Auto, too, then. So we also need to update create-svelte to use the latest version.
|
it's in a mergeable state so let's carry on in the other branch |
Rich-Harris
added a commit
that referenced
this pull request
Feb 6, 2023
* route level config wip * this seems to work * proper config * do shallow merge * docs * use config * default config * vercel docs * fix tests * appease TS * oops * more docs * this feels clunky * Route level config alt (#8863) * Revert "this feels clunky" This reverts commit b3b1b6e. * alternative approach to route-level config * remove hasRouteLevelConfig * handle data requests * simplify * fix types * remove unused code * fix site * fix default runtime * validate region, default to all for edge * "all" not ["all"] * changesets * make defaultConfig a separate option key * Update documentation/docs/25-build-and-deploy/90-adapter-vercel.md * implement split: true * tidy up * fix site * Update packages/adapter-vercel/index.d.ts * tweaks * get rid of top-level split option * union type * handle common case of one fn for everything separately to not pollute json for big apps * tweak docs a little * netlify * make external a config option and simplify adapter options interface * silence type union error * use platform defaults * include everything in builder.routes * implement ISR * fix some docs stuff * clarify multi-region serverless is only for enterprise * clarify memory stuff * document ISR * docs tweaks * fix site * add isr in config hash * bump adapter-auto etc * bump peerdeps --------- Co-authored-by: Rich Harris <[email protected]> Co-authored-by: Rich Harris <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to #8740 (comment). It's increasingly apparent that
builder.createEntriesis the wrong API — it tries to make it simple to merge routes into a single function, but the result is anything but.The approach here is much simpler — just expose the
RouteDefinitionobjects to the builder directly, and let it do whatever it wants.WIP — need to kick the tyres a bit more before committing
runtimeand other optionsallregion for edge functions, notiad1