Build Fails During (Due To?) Log Cleanup Added in @sveltejs/[email protected] #5577
Comments
cryptodeal
changed the title
cryptodeal
changed the title
elliott-with-the-longest-name-on-github
added
pkg:adapter-vercel
|
The immediate cause is that as of #5551, errors during dependency tracing ( kit/packages/adapter-vercel/index.js Lines 311 to 322 in 5b2dda4 It didn't occur to me that this would break apps that were otherwise functional. With my degree from the University of Google I can tell you that Going back to printing errors instead of throwing them would presumably fix this case, but it doesn't feel like the right long term solution. It feels like it might be a bug in |
|
Agree, would prefer to have best of both worlds in terms of the nicely cleaned up error logs & working builds; thanks for pointing me in the right direction! I've opened an issue in the @vercel/nft repo with the relevant info/links. |
Yes that is the correct solution. The warnings from nft are not errors, they are warnings. kit/packages/adapter-vercel/index.js Line 307 in 5b2dda4 |
|
@styfle is it right that I think part of my confusion stemmed from the fact that the type of |
Could be. I'm guessing something is attempting to read that file so nft trys to trace it. Which module is it coming from? |
I would argue all of them are safe to ignore. Imagine something like |
|
Thinking about this further: it makes sense that optional dependencies would result in a warning (that's what #5551 was about). But if |
Yeah it is a bit strange now that I think about it. We should parse |
|
Going to close this now that |
|
@Rich-Harris We had to revert that change because it caused more bugs. After further analysis, the real issue is that adatper is not setting the kit/packages/adapter-vercel/index.js Line 300 in 5b2dda4 |
|
My build is failing.... |
|
Is there any workaround?
i> kit/packages/adapter-vercel/index.js Line 300 in 5b2dda4 |
|
@styfle Can you elaborate? kit/packages/adapter-vercel/index.js Line 357 in 5b2dda4 I think we have to pin 0.22.0 until we can find an alternative approach, since 0.22.1 is causing build failures. |
|
@Rich-Harris The You can use Otherwise, you could try to detect workspaces the same way yarn/npm/pnpm does to find the monorepo root. |
Describe the bug
Using @sveltejs/[email protected], I can build a pnpm monorepo (using turborepo) locally, but deployment to Vercel fails with a cryptic error:
Same portion of logs when building locally:
The same project w/o any changes, but using pinned version @sveltejs/[email protected] deploys successfully (without the nice cleaned up build output ://).
I've linked a reproduction which has version @sveltejs/[email protected] and build fails. Additionally, I've copied the log files from the failed build on Vercel using 1.0.0-next.63 in it's entirety.
I've also previously deployed a version to Vercel in the same repo using 1.0.0-next.62 (no other file changes), which built/deployed to Vercel without issue; the build logs for this working deployment using 1.0.0-next.62 can be found here.
Reproduction
https://github.com/cryptodeal/adapter-vercel-build-error
Logs
System Info
System: OS: macOS 12.3.1 CPU: (8) arm64 Apple M1 Memory: 81.58 MB / 16.00 GB Shell: 5.8 - /bin/zsh Binaries: Node: 18.3.0 - ~/.nvm/versions/node/v18.3.0/bin/node Yarn: 1.22.18 - /opt/homebrew/bin/yarn npm: 8.12.2 - ~/.nvm/versions/node/v18.3.0/bin/npm Browsers: Brave Browser: 103.1.40.107 Chrome: 103.0.5060.114 Firefox: 101.0 Safari: 15.4 Safari Technology Preview: 16.0Severity
blocking an upgrade
Additional Information
Using SvelteKit in BallerAnalytics, a basketball analytics/fantasy insight platform, this blocks an upgrade.
Have worked around by pinning @sveltejs/[email protected] for the time being, but ultimately will prevent upgrading to latest version of adapter Vercel.
Additionally, Googling
vercel "usr/bin/ldd"produces only 2 results, one of which references @napi-rs, which is one of the dependencies listed in the errors that were displayed prior to the update released in version 1.0.0-next.63.The text was updated successfully, but these errors were encountered: