[prefer-destructured-store-props]: Allow methods?

[marekdedic]

Description

Hi,
I have a reactive map in a store (its a SvelteMap) and I am not really sure that's the correct way to do this. However, that's a little off topic. The thing is, the prefer-destructured-store-props rule is complaining when I use the get() method and I think that's a false positive?

It seems to me like methods should be allowed without destructuring. I am not an expert in reactivity in svelte, so I am not sure, though... What do you think?

[mikededo]

Would it be possible to have a repro or an example?

[marekdedic]

Here you go :)

[ota-meshi]

I have a reactive map in a store (its a SvelteMap) and I am not really sure that's the correct way to do this.

Hmm. I'm not sure if the user needs to wrap a SvelteMap in a store 🤔.
Shouldn't they just use a SvelteMap instance?

I don't think the rule is currently giving a false positive.

[marekdedic]

Honestly, I don't know -> sveltejs/svelte#14376

[marekdedic]

Ok, I resolved the linked discussion and you should indeed not use svelte/reactivity together with stores.

However, I am thinking my original issue still stands - the prefer-destructured-store-props rule is intended to prevent unneeded redraws when only some object properties change as fa as I understand it. However, when you call a function on something in a store, this probably doesn't apply? I mean you probably want a redraw every time the store changes because who knows what the function is doing?

[baseballyama]

Can you share some example code?

[marekdedic]

Hmm, I tried putting a class inside a store, but that doesn't really make sense as anything the class returns from its methods won't be reactive... So this probably isn't useful after all, sorry!