From 74373ec77aa9063c64657faefc01ca331e27b599 Mon Sep 17 00:00:00 2001 From: Yuichiro Yamashita Date: Tue, 14 Jan 2025 14:06:52 +0900 Subject: [PATCH] chore: do not run `no-reactive-reassign` rule on Svelte 5 with runes (#1014) --- .changeset/perfect-mirrors-doubt.md | 5 +++++ .../src/rules/no-reactive-reassign.ts | 11 ++++++++++- 2 files changed, 15 insertions(+), 1 deletion(-) create mode 100644 .changeset/perfect-mirrors-doubt.md diff --git a/.changeset/perfect-mirrors-doubt.md b/.changeset/perfect-mirrors-doubt.md new file mode 100644 index 000000000..413a80f92 --- /dev/null +++ b/.changeset/perfect-mirrors-doubt.md @@ -0,0 +1,5 @@ +--- +'eslint-plugin-svelte': patch +--- + +chore: do not run `no-reactive-reassign` rule on Svelte 5 with runes diff --git a/packages/eslint-plugin-svelte/src/rules/no-reactive-reassign.ts b/packages/eslint-plugin-svelte/src/rules/no-reactive-reassign.ts index f1da8a2ea..fb357cf89 100644 --- a/packages/eslint-plugin-svelte/src/rules/no-reactive-reassign.ts +++ b/packages/eslint-plugin-svelte/src/rules/no-reactive-reassign.ts @@ -27,7 +27,16 @@ export default createRule('no-reactive-reassign', { assignmentToReactiveValue: "Assignment to reactive value '{{name}}'.", assignmentToReactiveValueProp: "Assignment to property of reactive value '{{name}}'." }, - type: 'problem' + type: 'problem', + conditions: [ + { + svelteVersions: ['3/4'] + }, + { + svelteVersions: ['5'], + runes: [false, 'undetermined'] + } + ] }, create(context) { const props = context.options[0]?.props !== false; // default true