-
-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: update lucia adder #254
fix: update lucia adder #254
Conversation
|
commit: |
Cool, thanks! You can test the adder by running |
The generated TypeScript code works. I can't seem to get |
That's expected. The JSDoc in this instance is only included when |
Tested out with the published package and all the types seems to be working in both the TS and JSDoc version |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
much appreciated!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason this is still a draft?
…e' into update-lucia-example
thank you!! this is a big help we're hoping to add more things like oauth in the future. we're working on cleaning up some of our APIs to hopefully make it easier to add and maintain add-ons. really appreciate you taking a look! |
setSessionTokenCookie()
anddeleteSessionTokenCookie()
(closes lucia: addsetSessionTokenCookie
anddeleteSessionTokenCookie
methods #122)generateUserId()
to be consistent withgenerateSessionToken()
and easier to deal with.I haven't added change sets yet and I'm not sure how to test the adder.