-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Functionality of make_watertight #3
Comments
make_watertight should not further damage already water tight models, it should however have a beneficial action upon non watertight models. Currently on a non-watertight model the code does nothing, it performs various "fixing" actions but does not write these changes to file. In both our stand alone version and the meshkit version. |
Given the fixes to remove the segfault problems 513b71c, we can now focus investigation to issues as to why the models are not modified when the model is not watertight. |
In case it wasn't clear, a faceting tolerance of 1.0 causes many things to break down, originating from weird faceting from CGM. |
Determine the proper functioning of make_watertight on models that are water tight and those that are not water tight.
The text was updated successfully, but these errors were encountered: