Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Functionality of make_watertight #3

Open
makeclean opened this issue Mar 18, 2013 · 4 comments
Open

Functionality of make_watertight #3

makeclean opened this issue Mar 18, 2013 · 4 comments

Comments

@makeclean
Copy link
Contributor

Determine the proper functioning of make_watertight on models that are water tight and those that are not water tight.

@makeclean
Copy link
Contributor Author

make_watertight should not further damage already water tight models, it should however have a beneficial action upon non watertight models. Currently on a non-watertight model the code does nothing, it performs various "fixing" actions but does not write these changes to file. In both our stand alone version and the meshkit version.

@makeclean
Copy link
Contributor Author

Given the fixes to remove the segfault problems 513b71c, we can now focus investigation to issues as to why the models are not modified when the model is not watertight.

@makeclean
Copy link
Contributor Author

Test case 1, faceting tolerance 1.0e-2, produces the facet file shown in red, introducing a 0.1 deviation in the z coordinate of the last vertex produces the green.
screenshot from 2013-05-07 16 43 46

Zooming into the offset region,
screenshot from 2013-05-07 16 45 19

The desired behavior is that check_watertight determines that the model is not watertight at this tolerance, and then make_watertight should fix that vertex.

faceting tol 1.0e-1 1.0e-2 1.0e-3
check_watertight watertight not watertight not_watertight
make_watertight no changes no changes no changes

So the correct behavior would be to make no changes to the model for a faceting tolerance of 1.0e-1, but to fix the changes for other faceting tolerances.

@makeclean
Copy link
Contributor Author

In case it wasn't clear, a faceting tolerance of 1.0 causes many things to break down, originating from weird faceting from CGM.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant