Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add double-down job to CI for pull requests #733

Closed
pshriwise opened this issue Mar 23, 2021 · 1 comment
Closed

Add double-down job to CI for pull requests #733

pshriwise opened this issue Mar 23, 2021 · 1 comment

Comments

@pshriwise
Copy link
Member

I'm hoping to do a release of this package in the near future and word is that double-down is being used with DAGMC more frequently in the wild. As a result, I'll propose that we add it to CI to test PRs into DAGMC. This will avoid reactionary fixes in double-down/DAGMC to broken builds in the develop branch after merging. One example of this could have happened with #714 if I hadn't happened to test it with double-down locally.

I think I originally suggested that we only test double-down on merges to develop to mimic the experimental build functionality of Travis that is unavailable in CI, but I think that was a mistake for the reasons above.

@pshriwise pshriwise changed the title Add double-down to PR CI Add double-down job to CI for pull requests Mar 23, 2021
@gonuke
Copy link
Member

gonuke commented Jul 23, 2021

Resolved by #738

@gonuke gonuke closed this as completed Jul 23, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants