Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Change cursor color when the devil key sequences are in repeatable mode #19

Open
riz-ahmed opened this issue Oct 30, 2023 · 3 comments
Labels
enhancement New feature or request

Comments

@riz-ahmed
Copy link

Some key sequences in devil mode are repeatable such as ,ppp will result in C-p C-p C-p (moving down three lines). Can there be a way to indicate visually (a change in cursor color to some bright color would be rather cool) how long the devil key sequences are in repeatable mode.

This avoids the confusion if someone looses the track if they are still in repeatable mode or not. I actually tend to continue pressing p p p without realising that the repeat mode is already deactivated and tend to insert unseen bugs in my code.

Thank you!

@susam susam added the enhancement New feature or request label Nov 1, 2023
@fbrosda
Copy link

fbrosda commented Nov 2, 2024

I recently started using devil-mode and having a visual indicator, when it is possible to repeat some keys was something I really missed. So I made a quick draft, how this could be achieved: main...fbrosda:devil:highlight-repeatable

Before setting up a pull request I would like to have some feedback if this approach would be fine in general and how much should be customizable by the user?

@riz-ahmed
Copy link
Author

Hi, thanks for implementing this. Give a decent visual indication when devil mode is active. One improvement that I would suggest is to put back the mode line Color back to the default so that it doesn't mess up with colorscheme

@fbrosda
Copy link

fbrosda commented Nov 8, 2024

Thanks for the feedback. The version in the pull request now remembers the original colors and restores these. Note, the feature is disabled by default and you need to set devil-highlight-repeatable to t to activate it. Happy to incorporate further feedback, if there is any.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

3 participants