Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to ejs v3 #46

Closed
paimon0715 opened this issue Jul 26, 2021 · 4 comments
Closed

Update to ejs v3 #46

paimon0715 opened this issue Jul 26, 2021 · 4 comments

Comments

@paimon0715
Copy link

paimon0715 commented Jul 26, 2021

Hi,@surma @RReverser, I’d like to report a vulnerability introduced by package ejs:

Issue

A vulnerability is introduced in @surma/[email protected]:
Vulnerability SNYK-JS-EJS-1049328 is detected in package ejs (versions: <3.1.6): https://snyk.io/vuln/SNYK-JS-EJS-1049328
The above vulnerable package is referenced by @surma/[email protected] via:
1.@acanto/[email protected][email protected][email protected] ➔ @surma/[email protected][email protected]
2.@acpaas-ui/[email protected][email protected][email protected][email protected] ➔ @surma/[email protected][email protected]
3.@bentley/[email protected][email protected][email protected] ➔ @surma/[email protected][email protected]

Solution

Since @surma/[email protected] (1,619,886 downloads per week) is transitively referenced by 2,667 downstream projects (e.g., workbox-build 6.1.5 (latest version), workbox-webpack-plugin 6.1.5 (latest version), react-scripts 4.0.3 (latest version), next-offline 5.0.5 (latest version), @xdn/next 2.53.3 (latest version))

If @surma/[email protected].* removes the vulnerable package from the above version, then its fixed version can help downstream users decrease their pain.

Could you help update packages in these versions?

Fixing suggestions

In @surma/[email protected].*, you can kindly perform the following upgrade :
ejs ^2.6.1 ➔3.1.6;

Note:
[email protected](>=3.1.6) has fixed the vulnerability (SNYK-JS-EJS-1049328)

Thanks for your contributions to the downstream users!

Best regards,
Paimon

@surma
Copy link
Owner

surma commented Jul 26, 2021

I’ll take a look at updating it in due time. But note that ejs is only used at build time, so a code execution vulnerability in ejs is not really a threat in this context. You can already execute arbitrary code :D

@surma surma changed the title A vulnerability is introduced in your package Update to ejs v3 Jul 26, 2021
@paimon0715
Copy link
Author

@surma Thanks for your feedback.

@jeffposnick
Copy link
Contributor

Should this issue be closed? It seems like the ejs update happened?

@surma
Copy link
Owner

surma commented Oct 18, 2021

Oh it did indeed. lol. thank you

@surma surma closed this as completed Oct 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants