Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

upgrade to angular 5? #75

Open
dilotec-2015 opened this issue Nov 8, 2017 · 9 comments
Open

upgrade to angular 5? #75

dilotec-2015 opened this issue Nov 8, 2017 · 9 comments

Comments

@dilotec-2015
Copy link

dilotec-2015 commented Nov 8, 2017

could you upgrade the dependecies and HttpClient to angular 5?

it seems to work with angular 5, but after compilation i get following warning:

WARNING in ./node_modules/ng2-adal/node_modules/@angular/core/@angular/core.es5.js
5675:15-102 Critical dependency: the request of a dependency is an expression
at ImportLazyContextDependency.getWarnings (C:\xampp\htdocs\fox-backend-ng5\node_modules\webpack\lib\dependencies\ContextDependency.js:39:18)
at Compilation.reportDependencyErrorsAndWarnings (C:\xampp\htdocs\fox-backend-ng5\node_modules\webpack\lib\Compilation.js:703:24)
at Compilation.finish (C:\xampp\htdocs\fox-backend-ng5\node_modules\webpack\lib\Compilation.js:561:9)
at applyPluginsParallel.err (C:\xampp\htdocs\fox-backend-ng5\node_modules\webpack\lib\Compiler.js:506:17)
at C:\xampp\htdocs\fox-backend-ng5\node_modules\tapable\lib\Tapable.js:289:11
at _addModuleChain (C:\xampp\htdocs\fox-backend-ng5\node_modules\webpack\lib\Compilation.js:507:11)
at processModuleDependencies.err (C:\xampp\htdocs\fox-backend-ng5\node_modules\webpack\lib\Compilation.js:477:14)
at _combinedTickCallback (internal/process/next_tick.js:131:7)
at process._tickCallback (internal/process/next_tick.js:180:9)
@ ./node_modules/ng2-adal/node_modules/@angular/core/@angular/core.es5.js
@ ./node_modules/ng2-adal/dist/services/authHttp.service.js
@ ./node_modules/ng2-adal/dist/modules/authHttp.module.js
@ ./node_modules/ng2-adal/dist/modules.js
@ ./node_modules/ng2-adal/dist/core.js
@ ./src/app/app.module.ts
@ ./src/main.ts
@ multi webpack-dev-server/client?https://0.0.0.0:0 ./src/main.ts

@ToKaDev
Copy link

ToKaDev commented Nov 13, 2017

+1

@skorunka
Copy link

skorunka commented Nov 18, 2017

Do you guys plan to update this library to be compatible with ng5 (no warnings)? Thank you.

@skorunka
Copy link

What helped to me so far, is just to update the angular2-adal dependencies to the latest and npm i.

@godzillar
Copy link

I've got the same issue.

@teban1812
Copy link

+1

1 similar comment
@rjwijnen
Copy link

+1

@rjwijnen
Copy link

I tried to edit this library to support. Please check if helps you out: #77

@wrss2
Copy link

wrss2 commented Dec 4, 2017

+1 i compile and its working on 5.0.5 angular
it not create Authorization header and not conect with adal not creating iframe ;/

@test0017
Copy link

I am using ng2-adal and its showing WARNING in ./node_modules/ng2-adal/node_modules/@angular/core/@angular/core.es5.js warning when i upgraded the application in to Angular5
I have tried adal-angular5 and do-adal-angular5 , Its working but calling ng-init 2 times .
Please let me know about it .
Thanks .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

8 participants