Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect version 1.0.2 #66

Open
BennyM opened this issue Sep 18, 2017 · 6 comments
Open

Incorrect version 1.0.2 #66

BennyM opened this issue Sep 18, 2017 · 6 comments

Comments

@BennyM
Copy link

BennyM commented Sep 18, 2017

Today I was greeted with breaking builds because version 2.0 has been accidentally released as 1.0.2 and we allowed minor upgrades to take place. Perhaps release 1.0.3 which corrects this issue or unlist the package all together as it has been a mistake: https://docs.npmjs.com/cli/unpublish

Note to people using this library: either only allow the latest version which worked 1.0.1 or upgrade the code base to 2.0.0.

I'm posting this because other people will also encounter this.

It would also be helpful if release history and version information is available here on the repo.

@sureshchahal
Copy link
Owner

sorry for confusion. I cannot un publish as npm allow only 24 hours. I have submitted an request with npm to un publish it.

@Davilink
Copy link

Any news ?

@sureshchahal
Copy link
Owner

NPM have refused to unpublish this version . I will try to publish 1.0.3 sometime next week

@claudiuconstantin
Copy link

As per npm documentation:

It is generally considered bad behavior to remove versions of a library that others are depending on! Consider using the deprecate command instead, if your intent is to encourage users to upgrade

So you can just do a npm deprecate ng2-adal@"< 1.0.3" "upgrade to v1.0.3 is strongly recommended" after you publish the new 1.0.3

@nitinmidha
Copy link
Collaborator

nitinmidha commented Oct 1, 2017

I have published version 1.0.3 which is the current build from Angular2 branch. I have deprecated any versions below 1.0.3.

@sureshchahal
Copy link
Owner

@nitinmidha thanks. I will keep this open for few days so that people will have visibility in issue and what to do

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants