Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Properly clean up after federated account deletion #253

Closed
tsmethurst opened this issue Sep 28, 2021 · 1 comment
Closed

Properly clean up after federated account deletion #253

tsmethurst opened this issue Sep 28, 2021 · 1 comment
Labels
bug Something isn't working

Comments

@tsmethurst
Copy link
Contributor

tsmethurst commented Sep 28, 2021

Right now we handle account deletion like this:

https://github.com/superseriousbusiness/gotosocial/blob/main/internal/federation/federatingdb/delete.go#L89-L102

Ie., we just straight up remove the account from the database.

But then we don't handle side effects like removing followers:

https://github.com/superseriousbusiness/gotosocial/blob/main/internal/processing/fromfederator.go#L182-L185

This leads to bugs where going through followers/following lists fails because accounts pointed to by follows are removed (see #251).

We should implement proper exhaustive behavior for deleting accounts, so that stubs of follows/statuses/likes/etc aren't retained in the database at all.

After that we can consider rolling back the quickfix of #251

@tsmethurst
Copy link
Contributor Author

Closed by #254 but we might want to have another discussion about this at some point.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant