[bug] honk (benjojo) images shown with wrong image description

[mirabilos]

Describe the bug with a clear and concise description of what the bug is.

I complained about an image having a mere image description of…

z64KTcw2h2bZ8s67k2.jpg

… but the sender indicates this is supposed to be a GtS bug as he says he’s following spec “as far as [he] can see” in his own Fedi implementation. He attached the following document to support:

   {
      "actor": "https://benjojo.co.uk/u/benjojo",
      "id": "https://benjojo.co.uk/u/benjojo/honk/QZp4JrCv78N95hCgd1JQ",
      "object": {
        "attachment": [
          {
            "mediaType": "image/jpeg",
            "name": "z64KTcw2h2bZ8s67k2.jpg",
            "summary": "A very large panel that is entirely twist switches",
            "type": "Document",
            "url": "https://benjojo.co.uk/d/XzKw4M2Sc1pBxj3hY4.jpg"
          }
        ],
        "attributedTo": "https://benjojo.co.uk/u/benjojo",
        "content": "Finally a interface perfect for the gentoo users out there",
        "context": "data:,electrichonkytonk-8W1z23Q474f7b4N2JT",
        "conversation": "data:,electrichonkytonk-8W1z23Q474f7b4N2JT",
        "id": "https://benjojo.co.uk/u/benjojo/h/tk2Mfwj4m7vVS1Fm8L",
        "published": "2023-10-19T23:58:07Z",
        "summary": "",
        "to": "https://www.w3.org/ns/activitystreams#Public",
        "type": "Note",
        "url": "https://benjojo.co.uk/u/benjojo/h/tk2Mfwj4m7vVS1Fm8L"
      },
      "published": "2023-10-19T23:58:07Z",
      "to": "https://www.w3.org/ns/activitystreams#Public",
      "type": "Create"
    },

I’ve got no idea about AP JSON, but I’d appreciate if you could check whether this is indeed a GtS bug or a frontend bug or a bug on the sender’s side or something.

What's your GoToSocial Version?

0.11.1 git-c7a46e0

GoToSocial Arch

amd64 binary

What happened?

No response

What you expected to happen?

No response

How to reproduce it?

No response

Anything else we need to know?

No response

[tsmethurst]

Seen that as well yeah, think I know what's causing it. Thanks for raising it (I keep forgetting to do it).

I believe GtS checks name first and then summary when looking for an image description. I believe we just have to reverse those and check summary first, but I'll have to make sure when doing that we don't break alt text for some other implementation.

Edit: My bad, we didn't even check summary at all. I'll make a fix.