Use the CROSS MARK (U+274C) symbol for errors #159
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -72,7 +72,7 @@ module XCPretty | |||
| @formatter.format_duplicate_symbols("duplicate symbol _OBJC_IVAR_$ClassName._ivarName in", | |||
| ['/Users/username/Library/Developer/Xcode/DerivedData/App-arcyyktezaigixbocjwfhsjllojz/Build/Intermediates/App.build/Debug-iphonesimulator/App.build/Objects-normal/i386/ClassName.o', | |||
| '/Users/username/Library/Developer/Xcode/DerivedData/App-arcyyktezaigixbocjwfhsjllojz/Build/Products/Debug-iphonesimulator/libPods.a(DuplicateClassName.o)']).should == %Q( | |||
| #{@formatter.red("⌦ duplicate symbol _OBJC_IVAR_$ClassName._ivarName in")} | |||
| #{@formatter.red("❌ duplicate symbol _OBJC_IVAR_$ClassName._ivarName in")} | |||
There was a problem hiding this comment.
Prefer single-quoted strings inside interpolations.
| @@ -272,7 +272,7 @@ | |||
| end | |||
|
|
|||
| Then(/^I should see the undefined symbold message$/) do | |||
| run_output.should include(red("⌦ Undefined symbols for architecture x86_64")) | |||
| run_output.should include(red("❌ Undefined symbols for architecture x86_64")) | |||
There was a problem hiding this comment.
Prefer single-quoted strings when you don't need string interpolation or special symbols.
|
Sounds good. |
supermarin
added a commit
that referenced
this pull request
Oct 6, 2015
Use the CROSS MARK (U+274C) symbol for errors
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I always thought that the
⌦symbol was a glitch rather than the expected symbol for errors.