Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Autodetect terminal capabilities, update flags #136

Merged
merged 4 commits into from
Oct 8, 2015

Conversation

kattrali
Copy link
Contributor

Adds support for terminal capability detection for unicode and color, enabling where detected.

Fixes #70

Thoughts?

:formatter => XCPretty::Simple
}

def opt_bool(field, value)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

bool_option?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes far more sense. I've been writing too much C.

@kattrali kattrali added this to the 1.0.0 milestone Oct 6, 2015
@kattrali kattrali force-pushed the autodetect-capabilities branch from 0747905 to 83dc271 Compare October 6, 2015 20:38
@kattrali
Copy link
Contributor Author

kattrali commented Oct 6, 2015

Updated.

@supermarin
Copy link
Contributor

👍 👍 after comment

@kattrali kattrali force-pushed the autodetect-capabilities branch from e616942 to 3314d38 Compare October 6, 2015 22:57
@kattrali kattrali force-pushed the autodetect-capabilities branch from 3314d38 to c9ccd8b Compare October 7, 2015 03:47
@kattrali
Copy link
Contributor Author

kattrali commented Oct 8, 2015

Are we good here?

@supermarin
Copy link
Contributor

Yep :) sorry I've gotten used to giving thumbs and expecting the author to merge

supermarin added a commit that referenced this pull request Oct 8, 2015
Autodetect terminal capabilities, update flags
@supermarin supermarin merged commit ba0d6fd into master Oct 8, 2015
@supermarin supermarin deleted the autodetect-capabilities branch October 8, 2015 05:50
@angerman
Copy link

Shouldn't these changes be reflected in the readme as well? I still find -c without any explanation what -c does.

@supermarin
Copy link
Contributor

@angerman they should once we announce it in a release.

Would you like to submit a PR?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature request: Detect terminal feature support
3 participants