Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keycloak provider in signInWithIdToken method in the gotrue package #1045

Closed
Ppito opened this issue Sep 25, 2024 · 3 comments
Closed

Keycloak provider in signInWithIdToken method in the gotrue package #1045

Ppito opened this issue Sep 25, 2024 · 3 comments
Labels
enhancement New feature or request

Comments

@Ppito
Copy link
Contributor

Ppito commented Sep 25, 2024

I'm using Keycloak as my authentication provider and we need to use the signInWithIdToken method in our implementation.
The problem is that the gotrue package limits this method to the Google, Apple and Kakao providers : gotrue_client.dart
Looking at the NodeJs implementation of this same package and function, I noticed that there was no particular blockage to using the Keycloak provider : GoTrueClient.ts.

And indeed, by authorising Keycloak it works without any problem.

So my question is this: can you add this provider to the list of authorised providers?

@Ppito Ppito added the enhancement New feature or request label Sep 25, 2024
@dshukertjr
Copy link
Member

Sure, would you like to open a PR? Note that it seems like Keycloak is deprecated on the JS library, so there might be chances that it won't be supported in the future.

@Ppito
Copy link
Contributor Author

Ppito commented Sep 25, 2024

I'll be unavailable for the next 3 weeks, so if no-one in my team has done a PR I'll do it when I get back.

Keycloak is not deprecated, quite the contrary. He has joined the Cloud Native Computing Foundation and is strongly supported by the RedHat team.
They have restructured the various dev/tools they had and the old SDK is effectively deprecated but not the new one.

@Ppito
Copy link
Contributor Author

Ppito commented Oct 22, 2024

PR Merged.

Thanks again.

@Ppito Ppito closed this as completed Oct 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants