Add channels auth via JWT verification #99
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice work! |
|
Tested on Supabase AMIs - once again, awesome work @w3b6x9! |
|
🎉 This PR is included in version 0.10.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
soedirgo
added a commit
that referenced
this pull request
Jan 19, 2021
This is a followup to #99. All this means is it's no longer required for users to specify `SECRET_KEY_BASE` (which we don't use anyway).
soedirgo
added a commit
that referenced
this pull request
Jan 20, 2021
This is a followup to #99. All this means is it's no longer required for users to specify `SECRET_KEY_BASE` (which we don't use anyway).
soedirgo
added a commit
that referenced
this pull request
Jan 20, 2021
This is a followup to #99. All this means is it's no longer required for users to specify `SECRET_KEY_BASE` (which we don't use anyway).
Closed
kiwicopple
pushed a commit
to kiwicopple/realtime
that referenced
this pull request
Jun 9, 2021
kiwicopple
pushed a commit
to kiwicopple/realtime
that referenced
this pull request
Jun 9, 2021
This is a followup to supabase#99. All this means is it's no longer required for users to specify `SECRET_KEY_BASE` (which we don't use anyway).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Feature
What is the current behavior?
Channels are not secured
What is the new behavior?
Channels are secured by setting SECURE_CHANNELS=true and JWT_SECRET=your-secret
Additional context
By default in development mode everything should still work.
To test out channels auth set
SECURE_CHANNELS=trueandJWT_SECRET(e.g. secret123). I've been using http://jwtbuilder.jamiekurtz.com to generate JWTs and to play around with expiration and claims.I've been using the next-js example and passing the token param to Socket in realtime/examples/next-js/pages/index.js:
this.socket = new Socket(REALTIME_URL, { params: { token: 'token123' } })To validate claims set
JWT_CLAIM_VALIDATORS(e.g. {"iss": "Online JWT Builder", "aud": "www.example.com"}).This addresses issue #95.