Add database connection retries #82
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@soedirgo could you please review this one? I think it will solve some of the 500's we're seeing in production actually |
|
Looks good to me, tried this on a Supabase Postgres AMI and it can carry on connecting even when I blocked inbound connections inbetween. Nice work @w3b6x9! |
|
🎉 This PR is included in version 0.8.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
kiwicopple
pushed a commit
to kiwicopple/realtime
that referenced
this pull request
Jun 9, 2021
Prevents a temporary database connection error from shutting down entire server. When connection to database fails then the server will retry with exponential backoff and jitter, preventing server from shutting down.
kiwicopple
pushed a commit
to kiwicopple/realtime
that referenced
this pull request
Jun 9, 2021
This reverts commit 2a954b0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Prevents a temporary database connection error from shutting down entire server.
What is the current behavior?
When connection to database fails then the server shuts down because it tries to restart the epgsql process too quickly.
What is the new behavior?
When connection to database fails then the server will retry with exponential backoff and jitter, preventing server from shutting down.
Additional context
Tested this locally by restarting postgres.
NOTE: I think I discovered a better way as I was wrapping up this PR. Please hold off on merging.NOTE: Ready for review!