fix: Allow to set self host tenant name #1249
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Adds a new configurable variable to set self host tenant name. Authored-by: Scott Beardsley<[email protected]>
filipecabaco
force-pushed
the
fix/set-self-host-tenant-name
branch
from
b13df05 to
47aee4c
Compare
abc3
approved these changes
Dec 18, 2024
|
🎉 This PR is included in version 2.33.68 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
self-hosted seed update to allow tenant_name to be configurable via environment variable.
What is the current behavior?
The current behavior requires the container name to be "realtime-dev". If it isn't then it will not match the default tenant. In cases where the container name will be different (i.e. kubernetes deployments) it is impossible to use default tenant.
What is the new behavior?
The new behavior allows to configure the default tenant_name via an environment variable named TENANT_NAME with fallback behavior to the original "realtime-dev".
Additional context
This was an issue for the supabase-kubernetes project. I have submitted a PR there as well to overwrite the seeds.exs file in supabase-community/supabase-kubernetes#91
Ultimately it would be better to have this be configuration change upstream in this repo.