Fix ordering on JSON columns #132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `order` columns wrap the column name in quotes to allow characters like `.` without having the user wrap it manually, but this breaks on JSON columns, so we're removing the quotes.
|
Niice @soedirgo |
|
🎉 This PR is included in version 0.21.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
This was referenced Mar 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Bug fix.
What is the new behavior?
Previously,
ordercolumns wrap the column name in quotes to allowcharacters like
.without having the user wrap it manually, but thisbreaks on JSON columns, so we're removing the quotes.
Additional context
Closes #131.