Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: read env in auth.additional_redirect_urls values #2760

Merged

Conversation

jgoux
Copy link
Contributor

@jgoux jgoux commented Oct 11, 2024

What kind of change does this PR introduce?

feature

What is the current behavior?

The values in auth.additional_redirect_urls can't read from the env.

What is the new behavior?

The values in auth.additional_redirect_urls can read from the env. 😄

Additional context

I need that in order to have an environment agnostic configuration for the example I'm building showcasing social login in a Next.js app using @supabase-labs/nextjs.

In principle every time we have a config value being URL related, it should be able to read from the env.

Copy link
Member

@avallete avallete left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM waiting leaving the approval to qiao

Copy link
Contributor

@sweatybridge sweatybridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. We probably want to start doing this for every string field by adding a custom toml decode function.

@jgoux jgoux merged commit e51bc6c into develop Oct 11, 2024
17 checks passed
@jgoux jgoux deleted the jgoux/environment-reading-for-auth-additional-redirect-urls branch October 11, 2024 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants