fix: move MFA sub types to internal file #964
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
J0
commented
Sep 27, 2024
| /** Type of MFA factor. */ | ||
| type: 'phone' | ||
|
|
||
| /** Friendly name of the factor, useful for distinguishing between factors **/ |
There was a problem hiding this comment.
We only export the types file so this shouldn't get exposed
aloisklink
approved these changes
Oct 1, 2024
There was a problem hiding this comment.
I've tested this and it seems to work fine!
This is exactly what I was thinking of in #956 (comment) 🚀
Depending on your release/coding style, consider making this a refactor: commit/PR instead. It looks like you're automatically generating release notes from the commits, and so you might not want this to show up in the release notes, since it only "fixes" unreleased APIs!
(this is probably my main issue with conventional commits and automated changelogs, it's a bit difficult to mark a commit that changes unreleased behavior).
J0
commented
Oct 8, 2024
| if ( | ||
| error?.code === 'identity_already_exists' | ||
| ) { | ||
| if (error?.code === 'identity_already_exists') { |
hf
approved these changes
Oct 8, 2024
kangmingtay
pushed a commit
that referenced
this pull request
Oct 15, 2024
🤖 I have created a release *beep* *boop* --- ## [2.65.1](v2.65.0...v2.65.1) (2024-10-14) ### Bug Fixes * Call `SIGNED_OUT` event where session is removed ([#854](#854)) ([436fd9f](436fd9f)) * improve `mfa.enroll` return types ([#956](#956)) ([8a1ec06](8a1ec06)) * move MFA sub types to internal file ([#964](#964)) ([4b7455c](4b7455c)) * remove phone mfa deletion, match on error codes ([#963](#963)) ([ef3911c](ef3911c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What kind of change does this PR introduce?
Follow up to #956, hides the MFA sub-types (e.g. MFA Phone, MFA TOTP) needed to fix type errors before we release to public so that we can remove them as and when we like. The sub-types are now stored in an
internal-typesfile which, unlike thetypesfile is not exposed to public.The types mentioned here have not been released yet so fine to hide them