signIn to open flow in a pop-up or new tab

[Olyno]

Bug report

Describe the bug

Signin with a provider redirects the user to the associated provider. Problem: because the user didn't accept to login with his provider's account, we can't get the user, and because the redirection is happening after

await client.auth.signIn({ provider: 'google' });

So the user still "null"

To Reproduce

1. Create a new project
2. Adds a provider on a click event
3. See the problem

Expected behavior

Do not make any redirection. The best is probably to open all redirection in another windows, and when the user signins using the provider, then after that making the redirection if needed.

System information

• OS: Linux Deepin OS
• Browser (if applies) Chrome
• Version of supabase-js: ^1.18.1
• Version of Node.js: v14.16.1

[Olyno]

Related to this line: https://github.com/supabase/gotrue-js/blob/4575b2a116048b8226b5d4bd12a33777571b9b2a/src/GoTrueClient.ts#L448

[jimmiejackson414-zz]

I think I'm facing the same issue, and am not receiving a redirect of any sort either (though that might be slightly unrelated). I've posted about it in the Discussions as well as on StackOverflow

[megacherry]

Are there any news on this issue? :)

[Olyno]

After some discuss with @phamhieu on the discord, here is the real problem: the signIn method with a provider still return an object { user, session, error }, which is wrong because it executes an redirection. Due to that redirection, we're not able to get that data.

You still have the possibility to get the data using client.auth.user() or client.auth.session() BUT during the Supabase's internal loading, both values gonna be null. To fix that, you can use

client.auth.onAuthStateChange((_, session) => {
	setUser(session.user) // Example with React's hooks, just reassign your logged user here
})

[braebo]

With my use-case, onAuthStateChange doesn't fire.

I believe it's because I use a popup window. I can't let my main window redirect or reload because I need to preserve state (users can work offline, then login to save and continue working).

Consequently, I have a popup window handling Github auth, and inside the popup-window it redirects to /auth/success which displays a success screen before closing itself. It used to also pass the session back to the main window, but that no longer works (it worked a week or two ago iirc).

[awalias]

moving this to the backend repo

[praj18]

Has anyone found a solution for this year? I've seen various threads regarding the same issue with no solution in place

[jimmiejackson414-zz]

@praj18 not really a solution, but an explanation from I believe one of the team members to a StackOverflow post I made back in July.

[kangmingtay]

Hey everyone, i think this can be partially solved by just opening the OAuth provider in a separate tab rather than in the current window.

Problem: because the user didn't accept to login with his provider's account, we can't get the user, and because the redirection is happening after...So the user still "null"

This seems like expected behaviour. If the user hasn't completed the oauth login flow yet, no user object should be returned.

One other thing to note is that await client.auth.signIn({ provider: 'google' }); doesn't create a user in the auth schema until the redirection is complete.

[hf]

I moved this ticket from the GoTrue repo to here, and changed the title to make it clearer. This should be added to the library whenever we can get to it.

[hf]

With #566 this is probably going to become somewhat possible. Keeping the issue open as we need a proper API to launch the flow in a new tab / popup.

[hf]

Also #575 may make this even more possible.

[kangmingtay]

closing this issue because you can set skipBrowserRedirect: true in the signInWithOAuth method which will return a URL that you can open in the pop-up or a new tab

[ecancil]

closing this issue because you can set skipBrowserRedirect: true in the signInWithOAuth method which will return a URL that you can open in the pop-up or a new tab

So we're to implement the closing of the popup window and the communication back to the main window. Shouldn't this be very basic supported behavior?